Fix Nyan-Work#45 #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lithium will invoke the getCollisionShape() before the client instant is initialized. This is a hacky fix, preventing the calls to Configs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
在 Nyan-Work#45 中有两个bug：
与sodium不兼容，启动时出问题
实际上是因为调用
@WrapOperation的时候使用了magiclib的@WrapOperation而没有使用Operation。在
ModMenu的界面中滚动时会崩溃实际上是与
Lithium的不兼容导致的。在Lithium中会提前调用getCollisionShape()的函数，而在OMMC关于脚手架上禁止往下的功能中注入了这个函数，函数开头调用了Configs，这时并没有初始化MinecraftClient，因此对应的handler里初始时获取到的是null值，从而会导致崩溃。值得注意的是，这个修复的commit实际上比较hacky，可算是临时性的修复。进一步修复可能需要更改上游magiclib的相关函数。
以及以下bug:
sortInventory复制tag时tag可能为空在
.copyTags()时可能本身DataComponents就是空的，通过判断DataComponents是不是null修复CI need update
java 17的CI系统得稍微升级一下了（虽然只是修修补补，应该直接替换成MasaGadget那种之类的）