-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Load layers from image repository #133
Open
alukach
wants to merge
1
commit into
main
Choose a base branch
from
optimize/load-from-built-docker-images
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🍹
|
🍹
|
alukach
changed the title
IN PROGRESS: Load built layers from image repository
Load built layers from image repository
Dec 24, 2024
alukach
changed the title
Load built layers from image repository
Load layers from image repository
Dec 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I'm changing
Within this PR, we make use of the
cache_from
directive to load built image layers from GCR. This is described further within this blog post: https://www.pulumi.com/blog/build-images-50x-faster-docker-v4/Impact
I'm not totally certain how much impact this makes. It avoids building by fetching already-built layers, however that fetch operation does take time. I do believe there are some gains from this (largely from avoiding the
pip install
operations from within the container which don't seem to make use of any sort of cache), but probably not the 50x gains described in the aforementioned blog post.Before & After
Before
Total time of build & upload of docker:index:Image cerulean-cloud-images-test-cr-orchestrator-image:
0:03:22
After
Total time of build & upload of docker:index:Image cerulean-cloud-images-test-cr-orchestrator-image:
0:04:01
Note
So this change may have actually added time to the build process. I'm unsure if it should be retained or not.
I think a more impactful solution could be to retain the Pip cache used within the Docker image between builds. This would probably look like loading the cache in Github Actions, mounting to the docker image before building, and then saving back to Github Actions afterwards.