Build improvements #221
Open
Build improvements #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… library is not found
|
This PR has much less changes compared to the other ones, focusing on "build improvements", or problems I bumped into when I tried to build from source. Hopefully we can pass some more tests. The workflow yaml's themselves need a few things to not always fail, because they are missing dependencies, or are missing permissions to actually install with |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #221 +/- ##
==========================================
+ Coverage 47.25% 48.61% +1.35%
==========================================
Files 48 53 +5
Lines 3028 3785 +757
==========================================
+ Hits 1431 1840 +409
- Misses 1597 1945 +348 ☔ View full report in Codecov by Sentry. |
|
Thoughts? @Slackadays |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the cmake not to instantly fail if alsa is not installed without NO_ALSA being defined, and requires USE_ALSA to include alsa stuff.
Added missing dependencies missing on CI workflow files failed tests for the wrong reasons (many more like this, mostly with openssl or permissions with the install step)
Added the two other aliases for arm and x86 that uname -m can output.