Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(omnibar): ensure omnibar overlaps app content [#425] #772

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

mijogu
Copy link
Collaborator

@mijogu mijogu commented Jan 23, 2023

Lowers the z-index for dropdown menus in the header so that the omnibar is on top

@mijogu mijogu requested a review from acouch January 23, 2023 20:30
@mijogu mijogu self-assigned this Jan 23, 2023
@github-actions github-actions bot temporarily deployed to pr-772 January 23, 2023 20:30 Destroyed
Comment on lines +10 to +14

div[id^='slate-cbl-'][id*='-picker'],
.x-css-shadow {
z-index: 10 !important;
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not a good idea to monkey-patch the generated ExtJS styling like this, and the selector is liable to not catch everything ExtJS might put above the omnibar

A better approach instead of this would be to find the existing place where .slate-omnibar is assigned a z-index: 99 and set that to z-index: 999999 as our intention is that the omnibar should cover EVERYTHING. That way we don't have to get into whack-a-moleing specific things to be lower than it

@themightychris themightychris changed the title fixes #425 fix(omnibar): ensure omnibar overlaps app content [#425] Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants