Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[choreolib] Added more triggers #1159

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

[choreolib] Added more triggers #1159

wants to merge 14 commits into from
+215 −12

Conversation

oh-yes-0-fps
Copy link
Collaborator

No description provided.

shueja
shueja requested changes Jan 20, 2025
View reviewed changes
Copy link
Collaborator

@shueja shueja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this should be merged until we root-cause #1161.

choreolib/src/main/java/choreo/auto/AutoRoutine.java Outdated Show resolved Hide resolved
choreolib/src/main/java/choreo/auto/AutoTrajectory.java Outdated Show resolved Hide resolved
@Daniel1464
Copy link
Contributor

Maybe add a chain(Command, AutoTrajectory) overload? If that isnt clear enough you can call it thenRun instead of chain.

Also you should document it too.

@katzuv
Copy link
Contributor

katzuv commented Jan 21, 2025

Is it possible to add doneOverloads() and doneFor() overloads that take time? And basically multiply the time by 50.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shueja shueja shueja requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@oh-yes-0-fps @Daniel1464 @katzuv @shueja