Slicer build base auto update #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| def _run(cmd): | ||
| print("Executing %s" % ' '.join(cmd)) | ||
| subprocess.Popen(cmd) |
There was a problem hiding this comment.
This returns immediately. subprocess.check_call() would be a good alternative.
There was a problem hiding this comment.
Thanks for the tip.
Will look into it.
|
Haven't tested in full, but added some notes. Otherwise LGTM so far! |
Reviewed-by: Max Smolens <[email protected]>
jcfr
force-pushed
the
slicer-build-base-auto-update
branch
from
ef00dca to
2e2b485
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To facilitate the updated of
slicer-build-base/Dockerfile, I added the scriptupdated.sh(and its companion scriptupdate.py)Given the path to a Slicer source tree (setup with git-svn) it will update the Dockerfile and add a commit.
Todo:
@msmolens Let me know what you think.