Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow connecting to one specific server IP without broadcasting #301

Merged
merged 1 commit into from
Jan 19, 2024
Merged

feat: allow connecting to one specific server IP without broadcasting #301

merged 1 commit into from
Jan 19, 2024

Conversation

TheDevMinerTV
Copy link
Member

as @ButterscotchV requested, two flags to implicitly disable broadcast spamming the network. :)

@TheDevMinerTV
Copy link
Member Author

TheDevMinerTV commented Oct 31, 2023 •
edited
Loading

@ButterscotchV could you test this? I don't have a micro USB cable in my possession (finally) :D

@unlogisch04
Copy link
Contributor

I think for a test it is good enough.
But not for final. Because the server ip-address could be different each time. The main question for that feature is how the tracker gets used. So i would see that more in a config file and a serial config option.

unlogisch04
unlogisch04 approved these changes Nov 11, 2023
View reviewed changes
Copy link
Contributor

@unlogisch04 unlogisch04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on ESP8266 and ESP32C3.
Could connect over a router from Tracker IP 192.168.2.200 to the server 192.168.1.100

Even when i think it would be better to have a serial config for this.
But to have something is better to have nothing.

ButterscotchV
ButterscotchV approved these changes Jan 12, 2024
View reviewed changes
Copy link
Member

@ButterscotchV ButterscotchV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not tested, but looks fine (I don't have a very good way of testing).

@ButterscotchV ButterscotchV merged commit 2c8e41c into main Jan 19, 2024
2 checks passed
@ButterscotchV ButterscotchV deleted the feat/no-broadcast branch January 19, 2024 02:24
VOLCA2333 added a commit to VOLCA2333/SlimeVR-Tracker-ESP that referenced this pull request Feb 21, 2024
@VOLCA2333
feat: allow connecting to one specific server IP without broadcasting (…
8bf6ad3 
…SlimeVR#301)
l0ud pushed a commit to l0ud/SlimeVR-Tracker-ESP-BMI270 that referenced this pull request Apr 1, 2024
@TheDevMinerTV @l0ud
feat: allow connecting to one specific server IP without broadcasting (…
0c664f1 
…SlimeVR#301)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@unlogisch04 unlogisch04 unlogisch04 approved these changes

@ButterscotchV ButterscotchV ButterscotchV approved these changes

@Eirenliel Eirenliel Awaiting requested review from Eirenliel Eirenliel is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TheDevMinerTV @unlogisch04 @ButterscotchV