-
-
Notifications
You must be signed in to change notification settings - Fork 308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make I2Cscan non-blocking #378
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Tested to behave in a non-blocking way on official Slimes too when the IMU is misconfigured, though mine just prints that there's an I2C device on every address and pin, even with main firmware... |
Why remove most of the comments? |
portExclude is unused, comments seemed to clutter the code but if that's a dealbreaker I can add them back |
I agree that it is a little mess with the comments. For the portExclude thing, why i did add it: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks fine, will test in a few minutes, pls wait before merge
Works fine, tracker had BNO fuckery but it seems like it functions as intended and I was able to recover my tracker with OTA, no USB necessary 👍 |
Please don't merge without me testing it tomorrow or the day after. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wait for me testing it in one or two days.
Makes I2Cscan non-blocking, resolves #377. I could only test it with one IMU on ESP8266, where it still connected to wifi even when the IMU was not present at all, or on other pins/address. Needs further testing.