Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a Uranium plant #195

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Adds a Uranium plant #195

wants to merge 3 commits into from

Conversation

Skizzles
Copy link
Contributor

This adds a uranium plant that can be acquired from a Slime plant, requires a lot of progression and crafting to get to this along with some urganium.

@@ -220,6 +220,9 @@ private void registerItems() {
registerMagicalPlant("Slime", new ItemStack(Material.SLIME_BALL, 8), "90e65e6e5113a5187dad46dfad3d3bf85e8ef807f82aac228a59c4a95d6f6a",
new ItemStack[] {null, new ItemStack(Material.SLIME_BALL), null, new ItemStack(Material.SLIME_BALL), getItem("ENDER_PLANT"), new ItemStack(Material.SLIME_BALL), null, new ItemStack(Material.SLIME_BALL), null});

registerMagicalPlant("Uranium", new CustomItem(SlimefunItems.TINY_URANIUM, 1), "c8b29afa6d6dc923e2e1324bf8192750f7bdbddc689632a2b6c18d9fe7a5e",
new ItemStack[] {null, SlimefunItems.URANIUM, null, SlimefunItems.URANIUM, getItem("SLIME_PLANT"), SlimefunItems.URANIUM, null, SlimefunItems.URANIUM, null});
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if "Slime Plant" is the right base here for such an endgame plant, diamond or emerald seems more reasonable in my opinion.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Netherite plant might be more suiting if we talk end game.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diamond/Emerald is quite easy to get in most survival and sky environments so I feel netherite would be a good base for this plant as it would require the nether and obtaining the materials which are quite rare and would match the rarity of Uranium.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would make this plant only obtainable in 1.16+ though

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Require nether_star for base? Since Uranium is fairly high tier resource?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, sure. Perhaps keep the slime plant then and add a Nether star on top?

Changed Uranium plant requiring Slime to Netherite
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants