fix fallback!

SmartInvoiceXYZ · Dec 9, 2024 · 2674637 · 2674637
1 parent 2078844
commit 2674637
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 13 deletions.
diff --git a/apps/web/src/modules/proposal/components/ProposalDescription/MilestoneDetails.tsx b/apps/web/src/modules/proposal/components/ProposalDescription/MilestoneDetails.tsx
@@ -227,13 +227,5 @@ export const MilestoneDetails: React.FC<MilestoneDetailsProps> = ({
     }
   )
 
-  if (!decodedTxnData?._escrowData?.value) {
-    return (
-      <Text variant="code" color="negative">
-        Error Decoding Escrow Milestones
-      </Text>
-    )
-  }
-
   return <Accordion items={milestonesDetails || []} />
 }
diff --git a/apps/web/src/modules/proposal/components/ProposalDescription/ProposalDescription.tsx b/apps/web/src/modules/proposal/components/ProposalDescription/ProposalDescription.tsx
@@ -1,4 +1,4 @@
-import { Box, Flex, Paragraph, atoms } from '@zoralabs/zord'
+import { Box, Flex, Paragraph, Text, atoms } from '@zoralabs/zord'
 import { useEffect } from 'hono/jsx'
 import { toLower } from 'lodash'
 import Image from 'next/image'
@@ -53,6 +53,7 @@ export const ProposalDescription: React.FC<ProposalDescriptionProps> = ({
 }) => {
   const { description, proposer, calldatas, values, targets, executionTransactionHash } =
     proposal
+
   const { displayName } = useEnsData(proposer)
   const chain = useChainStore((x) => x.chain)
 
@@ -96,12 +97,19 @@ export const ProposalDescription: React.FC<ProposalDescriptionProps> = ({
             )}
           </Paragraph>
         </Section>
+
         {isEscrow && decodedTxnData && (
           <Section title="Escrow Milestones">
-            <MilestoneDetails
-              decodedTxnData={decodedTxnData}
-              executionTransactionHash={executionTransactionHash}
-            />
+            {executionTransactionHash ? (
+              <MilestoneDetails
+                decodedTxnData={decodedTxnData}
+                executionTransactionHash={executionTransactionHash}
+              />
+            ) : !decodedTxnData?._escrowData?.value ? (
+              <Text variant="code" color="negative">
+                Error Decoding Escrow Milestones
+              </Text>
+            ) : null}
           </Section>
         )}