Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: convert locations:rooms:create command to yargs #712

Merged
merged 1 commit into from
Mar 31, 2025
Merged

refactor: convert locations:rooms:create command to yargs #712

merged 1 commit into from
Mar 31, 2025

Conversation

rossiam
Copy link
Collaborator

@rossiam rossiam commented Mar 27, 2025

  • converted locations:rooms:create command to yargs
  • updated associated unit tests

@rossiam rossiam requested a review from a team March 27, 2025 17:22
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Mar 27, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: b863e81

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sitlintac
Sitlintac approved these changes Mar 31, 2025
View reviewed changes
src/commands/locations/rooms/create.ts
describe: 'the location for the new room',
type: 'string',
})
.example([
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add an example that uses the location option?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I think that's a good idea. I added on and also update the description for the one without it to indicate it would prompt for the location.

@rossiam rossiam force-pushed the yargs-locations-rooms-create branch from bf5740d to b863e81 Compare March 31, 2025 21:12
@rossiam rossiam merged commit 617a4b8 into SmartThingsCommunity:yargs Mar 31, 2025
4 checks passed
@rossiam rossiam deleted the yargs-locations-rooms-create branch March 31, 2025 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sitlintac Sitlintac Sitlintac approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rossiam @Sitlintac