Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a few smaller and bigger issues when it comes to performance loading 100k+ file collections.
Improvements
Tests with collections made from 10M+ dummy files reveal the following improvements. Numbers based on an older i7-5820K 6-Core desktop CPU.
Changes
skip_collection_counts
to avoid showing collection counts on startup, which can speed it up in case of large collections/vacation
would include/vacation2
or/vacation-eu
)Limitations / Breaking changes
This change introduces a limitation of max 50000 directories that can be sourced in a single collection. Considering the previously long loading time of such collections, this is probably not a big concern. If you hit this limitation, please let me know!