Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes to build to make packaging easier #23

Closed
attipaci opened this issue May 22, 2024 · 0 comments · Fixed by #25
Closed

Changes to build to make packaging easier #23

attipaci opened this issue May 22, 2024 · 0 comments · Fixed by #25
Assignees
@attipaci
Labels
enhancement New feature or request
Milestone
1.1.0

Comments

@attipaci
Copy link
Collaborator

attipaci commented May 22, 2024 •
edited
Loading

As we are planning to package SuperNOVAS for Debian and RPMFusion, we will probably want to update the build to make it
easier, e.g.:

  • Use CFLAGS / LDFLAGS defined externally (without editing config.mk).

  • Set CIO locator file location externally (without editing config.mk).

  • Add lib/supernovas.so target (with possibly versioned name).

  • Add lib/solsys1.so and lib/solsys2.so targets (bundling the related objects together).

  • It's strongly encouraged to add a major version to SONAME (even if the .so file name does not contain the version itself). Downstream packaging will typically want it.
@attipaci attipaci added the enhancement New feature or request label May 22, 2024
@attipaci attipaci added this to the Next bug fix release milestone May 22, 2024
@attipaci attipaci self-assigned this May 22, 2024
@attipaci attipaci changed the title Add versioning to generated .so file Changes to build to make packaging easier May 22, 2024
attipaci added a commit that referenced this issue May 22, 2024
@attipaci
Issue #23: Build improvements with easier packaging in mind
b03950e
@attipaci attipaci mentioned this issue May 22, 2024
Merged
@attipaci attipaci pinned this issue May 22, 2024
attipaci added a commit that referenced this issue May 22, 2024
@attipaci
Build improvements (and fixes) to facilitate downstream packaging (#25)
a9ecdfb 
* Issue #24: Fix SUPERNOVAS_VERSION_STRING macro

* Issue #23: Build improvements with easier packaging in mind

* cio_file.c: Fix warnings about unchecked return values

* version.c: Build utility for printing version string

* make to use externally defined LDFLAGS also when generating .so files

* Smarter make shared and make static implementations
@attipaci attipaci unpinned this issue May 27, 2024
@attipaci attipaci linked a pull request May 27, 2024 that will close this issue
Build improvements (and fixes) to facilitate downstream packaging #25
Merged
@attipaci attipaci modified the milestones: 1.0.2, 1.1.0 Jun 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@attipaci attipaci

Labels
enhancement New feature or request
Projects
None yet
Milestone
1.1.0
Development

Successfully merging a pull request may close this issue.

Build improvements (and fixes) to facilitate downstream packaging Smithsonian/SuperNOVAS
1 participant
@attipaci