Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build improvements (and fixes) to facilitate downstream packaging #25

Merged
merged 9 commits into from
May 22, 2024

Conversation

attipaci
Copy link
Collaborator

@attipaci attipaci added bug Something isn't working enhancement New feature or request labels May 22, 2024
@attipaci attipaci added this to the Next bug fix release milestone May 22, 2024
@attipaci attipaci self-assigned this May 22, 2024
Copy link

codecov bot commented May 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.79%. Comparing base (5afc6af) to head (817fddc).
Report is 4 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #25   +/-   ##
=======================================
  Coverage   98.79%   98.79%           
=======================================
  Files           3        3           
  Lines        1987     1987           
  Branches      370      370           
=======================================
  Hits         1963     1963           
  Misses          7        7           
  Partials       17       17           
Flag Coverage Δ
unittests 98.79% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af46ba6...817fddc. Read the comment docs.

@attipaci attipaci changed the title Build improvements (and fixes) Build improvements (and fixes) to facilitate downstream packaging May 22, 2024
@attipaci attipaci merged commit a9ecdfb into main May 22, 2024
8 checks passed
@attipaci attipaci deleted the improved-build branch May 22, 2024 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SUPERNOVAS_VERSION_STRING ill defined in novas.h Changes to build to make packaging easier
1 participant