New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Imprecise radial velocities in NOVAS C 3.1 #49

Closed

attipaci opened this issue Jul 30, 2024 · 0 comments · Fixed by #48

Assignees

Labels

bug

Milestone

Collaborator

attipaci commented Jul 30, 2024 •

edited

Loading

Radial velocities, as calculated in NOVAS C 3.1 (and previous SuperNOVAS) releases were not quite accurate because:

it used the aberrated source position, whereas the radial velocity should be measured towards the geometric source direction. This resulted in a typical error at the tens of m/s level.
it did not correctly account for the gravitational deflection in the radial velocity calculation. (What was done was in the wrong direction, and not quite right magnitude either). This resulted in a typical error at the few m/s level.

Both aspects will be corrected in v1.1

attipaci added the bug label

attipaci added this to the 1.1.0 milestone

attipaci self-assigned this

attipaci linked a pull request

that will close this issue

v1.1.0 release composition (part 2) #48

Merged

attipaci changed the title ~~Incorrect radial velocities in NOVAS C 3.1~~ Imprecise radial velocities in NOVAS C 3.1

attipaci closed this as completed in #48

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment