Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.1.0 release composition (part 2) #48

Merged
merged 16 commits into from
Aug 1, 2024
Merged

v1.1.0 release composition (part 2) #48

merged 16 commits into from
Aug 1, 2024

Conversation

attipaci
Copy link
Collaborator

@attipaci attipaci commented Jul 30, 2024

  • Radial velocity calculation now properly accounts for gravitational deflection (up to a few m/s change typically).
  • Fixes to how and when relativistic redhshift/blueshift corrections are applied in rad_vel().
  • Documentation updates
  • Minor code tweaks
  • Added tests

@attipaci attipaci added the enhancement New feature or request label Jul 30, 2024
@attipaci attipaci added this to the 1.1.0 milestone Jul 30, 2024
@attipaci attipaci self-assigned this Jul 30, 2024
Copy link

codecov bot commented Jul 30, 2024

Codecov Report

Attention: Patch coverage is 98.85057% with 1 line in your changes missing coverage. Please review.

Project coverage is 99.64%. Comparing base (9349da8) to head (e0cb3ec).

Files Patch % Lines
src/novas.c 98.57% 0 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #48      +/-   ##
==========================================
+ Coverage   99.60%   99.64%   +0.04%     
==========================================
  Files           6        6              
  Lines        2750     2784      +34     
  Branches      527      536       +9     
==========================================
+ Hits         2739     2774      +35     
+ Misses          1        0       -1     
  Partials       10       10              
Flag Coverage Δ
unittests 99.64% <98.85%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/frames.c 99.52% <100.00%> (+<0.01%) ⬆️
src/novas.c 99.58% <98.57%> (+0.05%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9349da8...e0cb3ec. Read the comment docs.

@attipaci attipaci linked an issue Jul 30, 2024 that may be closed by this pull request
@attipaci attipaci marked this pull request as ready for review July 31, 2024 09:38
@attipaci attipaci merged commit df7c5d1 into main Aug 1, 2024
15 checks passed
@attipaci attipaci deleted the compose-v1.1.0-part2 branch August 1, 2024 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
1 participant