Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/edan verifier utility #531
base: develop
Are you sure you want to change the base?
Feature/edan verifier utility #531
Changes from 16 commits
5e6a368
cb5de99
ccc10aa
c4afeb7
017d3b5
48514ed
1a61589
dca915c
ed94824
b7ca8a7
8d93a6c
4d5ff0f
aa291a6
0fb99f6
73b3a0e
ef4002d
7dbe9dc
94af4b6
756198b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The theory here is that you would pass these additional parameters to the workflow via
WorkkflowParameters.parameters
, which has typeany
, and can be populated with the config object needed by your specific workflow.If you do this, then you can simply
autoStart: true
, instead of doing a two-step process of creating, then starting, the workflow.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking this could be a default property vs. something specific to just the EDAN verifier. I'll look at how WorkflowEngine references this and update.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The key point here is that the workflow parameters exist to supply standard params, plus workflow-specific params. You can and should take advantage of that to pass all of the params into the workflow, instead of having to create it, then configure it, then start it. Just create it with the required params! If you do this, then you can probably autoStart: true it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With just 3K subjects, this will complete in minutes (5-10?). When Packrat has 300K subjects, this will need to be an offline process, run asynchronously. Why not just plan for that future now, and return an HTTP response of "EDAN Verifier Job Started" ... combined with emailing a link to the report upon completion?