Adds Nullability

[fabb]

No more make? inside blocks.

[fabb]

this is a bit awkward, i know, but otherwise the compiler will complain that the method should not return nil due to nullability.

[fabb]

ok, actually the view can be nil according to the comment, need to fix this in a new commit

[fabb]

ok, fixed it. fixed also the designated initializer which allows view to be nil too. did not fix the convenience initializer, as view ist used for both view and item there, and item may not be nil.

[fabb]

actually now did fix the convenience initializer, as the item property is weak and thus needs to be nullable

[fabb]

i mean, it could be forced that the parameter is non-nil in the initializer, and the property still can become nullable - but as the MASConstraintDelegateMock explicitly passes nil, I went with making it nullable.

[Panajev]

In this case either you change the method to expect a nil return value or you throw an exception there...

Both options may not be viable, but I personally find it very dangerous to have methods disobey their public API contracts. The compiler is right in this case.

Sent from my iPhone

On 31 Oct 2016, at 07:48, fabb [email protected] wrote:

@fabb commented on this pull request.

In Masonry/MASCompositeConstraint.m:

 self = [super init];

• if (!self) return nil;
• if (!self) return self;
  this is a bit awkward, i know, but otherwise the compiler will complain that the method should not return nil due to nullability.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

[fabb]

@Panajev:
Actually Apple's default implementation of init looks like this:

- (id)init {
    if (self = [super init]) {
        // code
    }
    return self;
}

This is exactly the same - also returns self when !self.