feat: fix env vars + update site metadata #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lesterli
approved these changes
Oct 26, 2024
bap2pecs
reviewed
Oct 28, 2024
src/config/index.ts
Outdated
There was a problem hiding this comment.
why are all the tests removed?
There was a problem hiding this comment.
this is legacy code copied from babylon's staking repo and not used in our code, so cleaned it up
bap2pecs
reviewed
Oct 28, 2024
|
|
||
| build: npm run build | ||
|
|
||
| build-docker: |
There was a problem hiding this comment.
I think we should still have build-docker
bap2pecs
approved these changes
Oct 28, 2024
bap2pecs
reviewed
Oct 28, 2024
Dockerfile
Outdated
Comment on lines
16
to
19
| COPY package.json . | ||
| COPY package-lock.json . | ||
|
|
||
| RUN npm run build | ||
| RUN npm install |
There was a problem hiding this comment.
i don't think we need these 3 lines. they are duplicate with
COPY package.json package-lock.json ./
# Install dependencies with npm
RUN npm ci
above
|
now it looks like this: 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR:
op-bridge-uiapproach)Test plan
Right click, click
Inspect->Elementstab -> check metadata included under<Header>tabFor live deployments, the social media preview should look like this:
Post-deployment
We need to update
babylon-deploymentby pulling the latest Docker image, and rebuild this site.