-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update evm_consumer functions implemented #2
base: base/consumer-chain-support
Are you sure you want to change the base?
Changes from 27 commits
289bbc4
d451545
9aa678e
e54e921
41cd722
caec997
c5c3c01
22873ab
e8398f7
3fa7927
feecc8f
aa9041a
252a328
5e6e9ad
79ce5c6
5119c64
79a0e20
77421c3
b992c72
257a441
4b3061e
d86f39c
c12ab96
43b1734
4329808
a589bb3
a612773
bb0007e
f3cf85b
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -56,6 +56,7 @@ build-docker: | |
|
||
.PHONY: test | ||
test: | ||
make mock-gen | ||
go test ./... | ||
|
||
test-e2e: | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -10,18 +10,21 @@ const ( | |
) | ||
|
||
type EVMConfig struct { | ||
RPCAddr string `long:"rpc-address" description:"address of the rpc server to connect to"` | ||
RPCL1Addr string `long:"rpc-address" description:"address of the L2 RPC server to connect to"` | ||
RPCL2Addr string `long:"rpc-address" description:"address of the L1 RPC server to connect to"` | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. "RPCL1Addr - address of the L2 RPC" There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. changed |
||
L2OutputOracleContractAddress string `long:"sol-address" description:"address of the L2output smart contract"` | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. L2output -> L2OutputOracle There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. changed |
||
BitcoinStackingContractAddress string `long:"sol-address" description:"address of the Bitcoinstaking smart contract"` | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. why this is also called what does "long" mean here? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. changed |
||
} | ||
|
||
func DefaultEVMConfig() EVMConfig { | ||
return EVMConfig{ | ||
RPCAddr: defaultEVMRPCAddr, | ||
RPCL2Addr: defaultEVMRPCAddr, | ||
} | ||
} | ||
|
||
func (cfg *EVMConfig) Validate() error { | ||
if _, err := url.Parse(cfg.RPCAddr); err != nil { | ||
return fmt.Errorf("rpc-addr is not correctly formatted: %w", err) | ||
if _, err := url.Parse(cfg.RPCL2Addr); err != nil { | ||
return fmt.Errorf("rpcl2-addr is not correctly formatted: %w", err) | ||
} | ||
return nil | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should not exist
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
deleted