Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat : QueryActivatedHeight() #3

Open
wants to merge 4 commits into
base: feat/QueryActivatedHeight
Choose a base branch
from

Conversation

XiangEnze
Copy link

@XiangEnze XiangEnze commented May 26, 2024

Summary

  • implement QueryActivatedHeight
  • add querynextBlockNumberto compute the block number of the next L2 block that needs to be checkpointed.
  • add queryBestBlockto find the first block where the block.number >= l1_activated_height in event OutputProposed
  • add codes and notes for l1 oracle contract VotingPowerUpdated event parts in comments
  • delete useless L2outputOracle parts
    - this pull request is not a completed request as functions are not fully implement, it can be used for discussion about the final designing for l1 oracle contract.

Next Steps:

  • implement QueryFinalityProviderVotingPower

Question:

  • How do we get votingPower from L1 oracle contract by tag, there will be function like getVotingPowerbyNumber() or we also find information in event?
  • As far as I understand, every time the votingPower is updated, an event VotingPowerUpdated will emit, but we always only need the number when it is first set ?
  • For the activatedHeight, do we still need find the first block from EOTSVerifier bigger than FP oracle activated height ?

Test Plan

make mock-gen
make test

@XiangEnze XiangEnze changed the title feat : query L2OutputOracle feat : QueryActivatedHeight() May 26, 2024
@XiangEnze XiangEnze requested a review from bap2pecs May 26, 2024 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant