Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #144 add start and end time to site #164

Merged
merged 1 commit into from
Oct 23, 2024
Merged

Issue #144 add start and end time to site #164

merged 1 commit into from
Oct 23, 2024

Conversation

micah-prime
Copy link
Contributor

Issue #144
Add a start and end time for pit start and end to Site

jomey
jomey reviewed Oct 23, 2024
View reviewed changes
snowexsql/tables/site.py Outdated Show resolved Hide resolved
jomey
jomey requested changes Oct 23, 2024
View reviewed changes
Copy link
Member

@jomey jomey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the new testing infrastructure, I think this change should also update the factory tests/factory and table level tests under tests/tables/

@micah-prime
Copy link
Contributor Author

With the new testing infrastructure, I think this change should also update the factory tests/factory and table level tests under tests/tables/

good call

@micah-prime micah-prime requested a review from jomey October 23, 2024 19:35
@micah-prime
Issue #144 add start and end time to site
2ef0fc0 
Add start and end time for 'Site' to factories. Make those times timezone aware

Tests with start and end time. Get rid of pitid in the layer data class
@jomey jomey merged commit 49a2025 into release-0.6.x Oct 23, 2024
6 checks passed
@jomey jomey deleted the issue144 branch October 23, 2024 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@micahjohnson150 micahjohnson150 Awaiting requested review from micahjohnson150 micahjohnson150 is a code owner

@jomey jomey Awaiting requested review from jomey jomey is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@micah-prime @jomey