Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop sample and flag column on layer data #166

Merged
merged 1 commit into from
Oct 23, 2024
Merged

Drop sample and flag column on layer data #166

merged 1 commit into from
Oct 23, 2024

Conversation

jomey
Copy link
Member

@jomey jomey commented Oct 23, 2024

Issue #165

@jomey
Tables - LayerData - Drop sample and flag columns
a8e9ca6 
This gets rid of columns sample_a|b|c and the flags column in favor of
storing three values for identical top and bottom height. The flags
column information will move to the comments. Also adding not-null and
index constraints for better data integrity.

Fixes #165
micah-prime
micah-prime approved these changes Oct 23, 2024
View reviewed changes
Copy link
Contributor

@micah-prime micah-prime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NICE

@jomey jomey merged commit 73b3ac3 into release-0.6.x Oct 23, 2024
6 checks passed
@jomey jomey deleted the issue_165 branch October 23, 2024 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@micah-prime micah-prime micah-prime approved these changes

@micahjohnson150 micahjohnson150 Awaiting requested review from micahjohnson150 micahjohnson150 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jomey @micah-prime