This repository has been archived by the owner on Oct 22, 2024. It is now read-only.
Updates pallet indices #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
claravanstaden
force-pushed
the
snowbridge
branch
from
63e2e83 to
c0ca774
Compare
| @@ -763,7 +763,7 @@ impl<Block: BlockT, BE: Backend<Block>> SubscriptionsInner<Block, BE> { | |||
| // blocks. | |||
| for hash in hashes.clone() { | |||
| if !sub.contains_block(hash) { | |||
| return Err(SubscriptionManagementError::BlockHashAbsent); | |||
| return Err(SubscriptionManagementError::BlockHashAbsent) | |||
There was a problem hiding this comment.
This is unrelated to this change. Let revert this because its going to get rejected when we merge upstream. I think our repos formatting rules are different.
There was a problem hiding this comment.
Sure! I think this is one of the few cases where the formatting rules are not applied in the polkadot-sdk. Reverted here 7d277bd.
This reverts commit 9442d90.
alistair-singh
approved these changes
Nov 27, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Snowbridge companion: Snowfork/snowbridge#1026