Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename control to system #1030

Merged
merged 6 commits into from
Dec 1, 2023
Merged

Rename control to system #1030

merged 6 commits into from
Dec 1, 2023

Conversation

yrong
Copy link
Contributor

@yrong yrong commented Nov 30, 2023

Just rename the file and batch replace
snowbridge_control to snowbridge_system
snowbridge-control to snowbridge-system
EthereumControl to EthereumSystem

Requires: Snowfork/polkadot-sdk#54

@yrong
Copy link
Contributor Author

yrong commented Nov 30, 2023

@vgeddes CI is green and e2e tests work as expected so should be fine, but it seems easier to merge #1015 first?

@yrong yrong marked this pull request as ready for review November 30, 2023 01:04
Copy link
Collaborator

@vgeddes vgeddes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copy link
Contributor

@alistair-singh alistair-singh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copy link

codecov bot commented Nov 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e4c9135) 81.50% compared to head (25777c1) 81.50%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1030   +/-   ##
=======================================
  Coverage   81.50%   81.50%           
=======================================
  Files          54       54           
  Lines        2233     2233           
  Branches       70       70           
=======================================
  Hits         1820     1820           
  Misses        398      398           
  Partials       15       15           
Flag Coverage Δ
rust 81.45% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yrong yrong merged commit d684f6c into main Dec 1, 2023
9 checks passed
@yrong yrong deleted the ron/control-to-system branch December 1, 2023 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants