Make base fee configurable from storage. #1060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alistair-singh
commented
Dec 16, 2023
parachain/runtime/tests/src/lib.rs
Outdated
| @@ -5,7 +5,7 @@ | |||
|
|
|||
| mod test_cases; | |||
|
|
|||
| use asset_hub_rococo_runtime::xcm_config::bridging::to_ethereum::BridgeHubEthereumBaseFeeInROC; | |||
| use asset_hub_rococo_runtime::xcm_config::bridging::to_ethereum::DefaultBridgeHubEthereumBaseFeeInROC; | |||
There was a problem hiding this comment.
Using the const version in the tests as the storage version causes it to panic due to there is no underlying storage provider.
alistair-singh
force-pushed
the
alistair/make-base-fee-storage
branch
from
b60864a to
6ee36eb
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1060 +/- ##
=======================================
Coverage 81.30% 81.30%
=======================================
Files 54 54
Lines 2241 2241
Branches 71 71
=======================================
Hits 1822 1822
Misses 402 402
Partials 17 17
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Polkadot-sdk: Snowfork/polkadot-sdk#68