Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run Smoke Tests in CI #1144

Merged
merged 54 commits into from
Mar 5, 2024
Merged

Run Smoke Tests in CI #1144

merged 54 commits into from
Mar 5, 2024

Conversation

claravanstaden
Copy link
Contributor

@claravanstaden claravanstaden commented Feb 20, 2024 •
edited
Loading

Adds:

  • Http service to the beacon relayer to check if the relayer is running
  • Bash script to run the smoke tests
  • Bash script to check if the beacon relayer is running
  • Minor changes to get the e2e stack to work in GA

Resolves: SNO-857
Polkadot-sdk companion: Smoke Tests in CI #113

@claravanstaden claravanstaden marked this pull request as ready for review February 26, 2024 17:47
@claravanstaden claravanstaden mentioned this pull request Feb 26, 2024
Merged
alistair-singh
alistair-singh reviewed Feb 27, 2024
View reviewed changes
scripts/init.sh Outdated Show resolved Hide resolved
relayer/cmd/run/beacon/command.go Outdated Show resolved Hide resolved
web/packages/test/scripts/run-smoketests.sh Show resolved Hide resolved
@alistair-singh
Copy link
Contributor

Why do we need the health check?

@claravanstaden
Copy link
Contributor Author

@alistair-singh The start-services.sh script is run in the background: https://github.com/Snowfork/polkadot-sdk/pull/113/files#diff-ebcd3a3b6186ad4cf5cf2337ff84cc4692492610301fefb171509d671bf9f507R62

So I needed a way to know if the E2E stack is complete. I'm open to better ideas. 😅 I guess I could just check if the relayer process is running 🤷🏻‍♀️

yrong
yrong approved these changes Mar 4, 2024
View reviewed changes
Copy link
Contributor

@yrong yrong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

@claravanstaden claravanstaden merged commit 637cb1c into main Mar 5, 2024
0 of 2 checks passed
@claravanstaden claravanstaden deleted the smoketests-ci branch March 5, 2024 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alistair-singh alistair-singh alistair-singh left review comments

@yrong yrong yrong approved these changes

@vgeddes vgeddes Awaiting requested review from vgeddes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@claravanstaden @alistair-singh @yrong