Add register ether command to control tool #1361
Conversation
| pub fn get_ether_id(chain_id: u64) -> Location { | ||
| return Location { | ||
| parents: 2, | ||
| interior: X1([GlobalConsensus(NetworkId::Ethereum { chain_id })]), | ||
| }; | ||
| } |
There was a problem hiding this comment.
Please check paritytech/polkadot-sdk#6855 (comment)
There was a problem hiding this comment.
This was merged by parity before discussing with Vincent. But I think we would like it to be { parents: 2, interior: X1([GlobalConsensus(Ethereum { chain_id: 1 })]) } because in XCM this is the convention. I.e. The relaychain token and the destination of the relaychain share the same location. So in our case the bridge location and the bridge native token also shares the same location.
alistair-singh
force-pushed
the
alistair/control-tool-register-eth
branch
from
b6ffe80 to
ad05a6e
Compare
alistair-singh
force-pushed
the
alistair/control-tool-register-eth
branch
from
ad05a6e to
8490979
Compare
control/preimage/src/main.rs
Outdated
| #[arg(long, value_name = "ASSET_DISPLAY_NAME", default_value_t = String::from("Ether"))] | ||
| ether_name: String, | ||
| /// The Ether asset symbol | ||
| #[arg(long, value_name = "ASSET_SYMBOL", default_value_t = String::from("ETH.e"))] |
There was a problem hiding this comment.
I thought it was only bridge UIs that appended ".e" to the token symbol?
Shouldn't we default to "ETH" to be consistent with "WETH" registered on AssetHub?
There was a problem hiding this comment.
Resolved in 9132e64
Resolves: SNO-1222, SNO-1251