Anvil Saving #168
Draft
Anvil Saving #168
+431
−108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Comment: d0b6805 added the ability to save chunks to anvil, but converting chunks into bytes is still not done. |
Snowiiii
reviewed
Oct 21, 2024
pumpkin-world/src/chunk/anvil.rs
Outdated
Comment on lines
90
to
145
| fn modulus(a: i32, b: i32) -> i32 { | ||
| ((a % b) + b) % b | ||
| } |
There was a problem hiding this comment.
You never can have enough of modulus functions right 😉
pumpkin-world/src/chunk/anvil.rs
Outdated
Comment on lines
182
to
243
| let region = ( | ||
| ((at.x as f32) / 32.0).floor() as i32, | ||
| ((at.z as f32) / 32.0).floor() as i32, | ||
| ); |
There was a problem hiding this comment.
We use this also for reading, would probably make sense to have it as a function
|
I also noticed that there is no compression yet |
lukas0008
force-pushed
the
world-saving
branch
3 times, most recently
from
872dc7e
to
bd357b0
Compare
`BlockString` is yet another representation of `BlockId`/`BlockState`, but this time it is a string representation.
- Actually write the location table correctly - Stop using windows exclusive .seek_read/write functions
|
Yooo good job @Snowiiii :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr aims to add world saving using minecraft .mca files to pumpkin.