Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle client ping requests #351

Merged
merged 2 commits into from
Nov 30, 2024
Merged

Handle client ping requests #351

merged 2 commits into from
Nov 30, 2024

Conversation

neeleshpoli
Copy link
Contributor

Description

Handle the ping requests sent by the client. Seems like all the code already exists, but it was never added to the deserialization process 🤷‍♂️ .

Testing

Joining the server, opening Debug + Bandwidth and Ping (F3 +3).

Checklist

Things need to be done before this Pull Request can be merged.

  • Add packet to play packet deserialization process
  • Code is well-formatted and adheres to project style guidelines: cargo fmt
  • Code does not produce any clippy warnings: cargo clippy
  • All unit tests pass: cargo test
  • I added new unit tests, so other people don't accidentally break my code by changing other parts of the codebase. How?

@Snowiiii
Copy link
Owner

Upsi. Seems like i forgot that when Porting from the Enum Packet

@Snowiiii Snowiiii merged commit 136c0fc into Snowiiii:master Nov 30, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants