Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make asset extraction a local action #366

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kralverde
Copy link
Contributor

@kralverde kralverde commented Dec 3, 2024

Description

With changes with minecraft versions, asset files can have massive changes causing a lot of bloat on the git repo that can lead to MBs of extra un-needed data.

This PR introduces a script to generate and move asset files from the extractor to their locations in the project root.

Checklist

Things need to be done before this Pull Request can be merged.

  • Update workflows to add a compressed archive of extracted files for those who don't want to extract them locally themselves
  • Update workflows to extract assets before building
  • Add windows scripts
  • Add bash scripts
  • Code is well-formatted and adheres to project style guidelines: cargo fmt
  • Code does not produce any clippy warnings: cargo clippy
  • All unit tests pass: cargo test

@kralverde kralverde changed the title Make asset extraction an local action Make asset extraction a local action Dec 3, 2024
@kralverde kralverde marked this pull request as ready for review December 4, 2024 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant