Add permissions check for SSetCreativeSlot #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You have a good commit message, Why you don't use that for the PR description. There are many people using "self explanatory commit" or something like this in PR and i really hate it. So would be cool if you could use good commit messages and good PR descriptions in the future 👍 |
|
updated my PR message :) |
Bryntet
changed the title
Snowiiii
reviewed
Aug 21, 2024
pumpkin/src/client/player_packet.rs
Outdated
Comment on lines
403
to
407
| let gamemode = self.player.as_ref().unwrap().gamemode; | ||
| if gamemode != GameMode::Creative { | ||
| self.kick("CHEATER") | ||
| } | ||
| let inventory = &mut self.player.as_mut().unwrap().inventory; |
There was a problem hiding this comment.
Why we should &mut self.player.as_mut() twice when we also could just do it once ?
There was a problem hiding this comment.
because the borrow checker yells at me if i try to have a mut ref to player (that gets used later, so it can't be dropped) when doing self.kick (which requires &mut)
Snowiiii
requested changes
Aug 21, 2024
There was a problem hiding this comment.
let player = self.player.as_mut().unwrap();
if player.gamemode != GameMode::Creative {
self.kick("Invalid action, you can only do that if you are in creative");
return;
}
player
.inventory
.set_slot(packet.slot as usize, packet.clicked_item.to_item(), false);
|
that should be fixed now |
|
Looks good, Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make sure the players gamemode is creative when client sends SSetCreativeSlot