Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added remaining entity type ids #64

Closed
wants to merge 2 commits into from
Closed

Conversation

earomc
Copy link

@earomc earomc commented Aug 28, 2024

Not that crazy. I wrote a quick lil program to generate them for me from the registry.json. So that I could copy paste them over. Maybe you're interested in that. We should probably use a proper registry for that stuff in the future tho.

@Snowiiii
Copy link
Owner

Looks good. But sure there are that few entities ?. I tought mc had like 1000 of them. I also would like to have the generator somewhere in case of an new update

@earomc
Copy link
Author

earomc commented Aug 29, 2024

No, no, 129 sounds about right in terms of entities, not counting block entities or entity variants (e.g. cats, wolfs, llamas etc.). And there are 129 entries in the entity_type entries list as of now.

About the generator: It's a separate Rust project with about 20 lines of code. Didn't want to include it in the commit tho. If you want I can send it as a gist or whatever.

@Snowiiii
Copy link
Owner

No, no, 129 sounds about right in terms of entities, not counting block entities or entity variants (e.g. cats, wolfs, llamas etc.). And there are 129 entries in the entity_type entries list as of now.

About the generator: It's a separate Rust project with about 20 lines of code. Didn't want to include it in the commit tho. If you want I can send it as a gist or whatever.

If would like to have this tool included in pumpkin somewhere (if you want)

@Snowiiii
Copy link
Owner

Snowiiii commented Sep 4, 2024

Hey, Until CI is failing nothing will be merged. This is also the case for your other open PR

@Snowiiii Snowiiii closed this Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants