chore(api): refactor checkIsDFFReadyToBeSentToCertificationAuthorityB…

…yId to use only essential inputs
SocialGouv · Nov 12, 2024 · 1518fda · 1518fda
1 parent 2e128ee
commit 1518fda
Show file tree

Hide file tree

Showing 2 changed files with 43 additions and 20 deletions.
diff --git a/.../feasibility/dematerialized-feasibility-file/dematerialized-feasibility-file.resolvers.ts b/.../feasibility/dematerialized-feasibility-file/dematerialized-feasibility-file.resolvers.ts
@@ -88,11 +88,25 @@ const unsafeResolvers = {
         aapDecision,
         eligibilityRequirement,
       }),
-    isReadyToBeSentToCertificationAuthority: (
-      dematerializedFeasibilityFile: DematerializedFeasibilityFile,
-    ) =>
+    isReadyToBeSentToCertificationAuthority: ({
+      attachmentsPartComplete,
+      certificationPartComplete,
+      competenceBlocsPartCompletion,
+      prerequisitesPartComplete,
+      aapDecision,
+      eligibilityRequirement,
+      swornStatementFileId,
+      candidateConfirmationAt,
+    }: DematerializedFeasibilityFile) =>
       checkIsDFFReadyToBeSentToCertificationAuthorityById({
-        dematerializedFeasibilityFile,
+        attachmentsPartComplete,
+        certificationPartComplete,
+        competenceBlocsPartCompletion,
+        prerequisitesPartComplete,
+        aapDecision,
+        eligibilityRequirement,
+        swornStatementFileId,
+        candidateConfirmationAt,
       }),
     swornStatementFile: ({
       swornStatementFileId,

diff --git a/...rialized-feasibility-file/features/checkIsDFFReadyToBeSentToCertificationAuthorityById.ts b/...rialized-feasibility-file/features/checkIsDFFReadyToBeSentToCertificationAuthorityById.ts
@@ -1,21 +1,30 @@
-import { DematerializedFeasibilityFile } from "@prisma/client";
+import {
+  CompetenceBlocsPartCompletionEnum,
+  DFFDecision,
+  DFFEligibilityRequirement,
+} from "@prisma/client";
 
-export const checkIsDFFReadyToBeSentToCertificationAuthorityById = async ({
-  dematerializedFeasibilityFile,
-}: {
-  dematerializedFeasibilityFile: DematerializedFeasibilityFile;
-}) => {
-  const {
-    attachmentsPartComplete,
-    certificationPartComplete,
-    competenceBlocsPartCompletion,
-    prerequisitesPartComplete,
-    aapDecision,
-    swornStatementFileId,
-    candidateConfirmationAt,
-    eligibilityRequirement,
-  } = dematerializedFeasibilityFile;
+type CheckIsDFFReadyToBeSentToCertificationAuthorityByIdArgs = {
+  attachmentsPartComplete: boolean;
+  certificationPartComplete: boolean;
+  competenceBlocsPartCompletion: CompetenceBlocsPartCompletionEnum;
+  prerequisitesPartComplete: boolean;
+  aapDecision: DFFDecision | null;
+  eligibilityRequirement: DFFEligibilityRequirement | null;
+  swornStatementFileId: string | null;
+  candidateConfirmationAt: Date | null;
+};
 
+export const checkIsDFFReadyToBeSentToCertificationAuthorityById = async ({
+  attachmentsPartComplete,
+  certificationPartComplete,
+  competenceBlocsPartCompletion,
+  prerequisitesPartComplete,
+  aapDecision,
+  eligibilityRequirement,
+  swornStatementFileId,
+  candidateConfirmationAt,
+}: CheckIsDFFReadyToBeSentToCertificationAuthorityByIdArgs) => {
   let isDFFReadyToBeSentToCertificationAuthority =
     attachmentsPartComplete &&
     certificationPartComplete &&