Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/#729 refacto de la table hebergement v 2 #617

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

benjaminDNUM
Copy link
Contributor

@benjaminDNUM benjaminDNUM commented Nov 19, 2024

close jira : https://jira-mcas.atlassian.net/browse/VAO-637?atlOrigin=eyJpIjoiY2RiYmRlZmExMWQ4NDQ4ZGExMDRiN2FlOGZhZWZiNDkiLCJwIjoiaiJ9

Dans cette PR, on se debarasse de tous les appels ds.hebergement et des jsons dans la table hebergement pour recuperer de la données

@benjaminDNUM benjaminDNUM force-pushed the fix/#729-refacto-de-la-table-hebergement-v-2 branch from 1d067f1 to ad40a56 Compare November 19, 2024 14:35
@benjaminDNUM benjaminDNUM force-pushed the fix/#729-refacto-de-la-table-hebergement-v-2 branch from ad40a56 to 1607870 Compare November 20, 2024 14:05
@benjaminDNUM benjaminDNUM force-pushed the fix/#729-refacto-de-la-table-hebergement-v-2 branch from 1607870 to 7c1d9ed Compare November 20, 2024 14:49
@benjaminDNUM benjaminDNUM force-pushed the fix/#729-refacto-de-la-table-hebergement-v-2 branch from 7c1d9ed to 4cd710b Compare November 20, 2024 16:12
@benjaminDNUM benjaminDNUM force-pushed the fix/#729-refacto-de-la-table-hebergement-v-2 branch from 4cd710b to d3f00c0 Compare November 20, 2024 16:37
@benjaminDNUM benjaminDNUM force-pushed the fix/#729-refacto-de-la-table-hebergement-v-2 branch from d3f00c0 to 688305d Compare November 21, 2024 08:13
@benjaminDNUM benjaminDNUM force-pushed the fix/#729-refacto-de-la-table-hebergement-v-2 branch from 688305d to e8c37f9 Compare November 21, 2024 08:16
Copy link

sonarcloud bot commented Nov 21, 2024

@benjaminDNUM benjaminDNUM marked this pull request as ready for review November 21, 2024 13:35
Copy link

🎉 Deployment for commit b20168e :

Ingresses
Docker images
  • 📦 docker pull harbor.fabrique.social.gouv.fr/vao/vao/backend:sha-b20168e3684be75c4cbbeeaf5b3f338c9a71d0da
  • 📦 docker pull harbor.fabrique.social.gouv.fr/vao/vao/frontend-bo:sha-b20168e3684be75c4cbbeeaf5b3f338c9a71d0da
  • 📦 docker pull harbor.fabrique.social.gouv.fr/vao/vao/frontend-usagers:sha-b20168e3684be75c4cbbeeaf5b3f338c9a71d0da
  • 📦 docker pull harbor.fabrique.social.gouv.fr/vao/vao/migrations:sha-b20168e3684be75c4cbbeeaf5b3f338c9a71d0da
  • 📦 docker pull maildev/maildev:2.1.0
Debug

FROM front.demande_sejour ds
INNER JOIN front.organismes o ON o.id = ds.organisme_id
LEFT JOIN front.agrements agr ON agr.organisme_id = ds.organisme_id
WHERE ds.id = $1
`;

const queryHebegements = `
SELECT DISTINCT
A.DEPARTEMENT AS DEPARTEMENT
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mettre au moins AS "departement" pour pas se trainer un truc bizarre dans le code

@@ -92,7 +92,14 @@ EIG.ID,
DS.PERSONNEL -> 'encadrants' as "encadrants",
DS.PERSONNEL -> 'accompagnants' as "accompagnants",
DS.STATUT as "dsStatut",
JSONB_PATH_QUERY_ARRAY(DS.HEBERGEMENT,'$.hebergements.coordonnees.adresse.label') as "adresses",
(SELECT DISTINCT
ARRAY_AGG(A.LABEL)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mettre un alias as "label"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants