fix: explicit fields for CreateSecurityGroupRequest #10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change theCreateSecurityGroupRequest
to include fields of specific data required for creating a security group. This deviates from the request objects only using a "Template" field. The idea is here is so that manifold has an explicit contract and handles marshaling. This PR's implementation of marshaling could be improved (e.g. helper funcs) but this is more of a POC.Status quo requires the caller of manifold to marshal a string payload everywhere.Could this be a pattern we want to follow going forward?Moving forward with SetTemplate() by the caller. This PR just adds new security group rules.