-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SOL-115142: Added HowToImplementTracingManualInstrumentation #38
Conversation
FOR THE REVIEWER(probably @Mrc0113 or @aaron-613 ??) I based this snippet off the JCSMP one for manual instrumentation . However, the JCSMP samples project has a separate folder called Can be found here. This samples project does not have a |
@Mrc0113 @aaron-613 PS+ Java 1.7.0 & Java OTEL 1.0.0 are both released now. So I am changing this PR from a draft to ready-for-review! |
Hey @aelsammak , I'm gonna be taking a look at this now! Just wondering, did you check out the updates to JCSMP samples that Jamil made a while ago? He modified/tweaked a lot of the samples that R&D produced. https://github.com/SolaceSamples/solace-samples-java-jcsmp/tree/master/src/main/java/com/solace/samples/jcsmp/features/distributedtracing |
Hello @aaron-613, I did check out the updates by Jamil and I see several classes were added to the "features" folder. I left a comment about this here: #38 (comment) |
src/main/java/com/solace/samples/java/snippets/HowToImplementTracingManualInstrumentation.java
Outdated
Show resolved
Hide resolved
src/main/java/com/solace/samples/java/snippets/HowToImplementTracingManualInstrumentation.java
Outdated
Show resolved
Hide resolved
Updated the code, mostly Gradle and Maven JAR dependencies, fixed some warnings. |
@aaron-613 Good catches! I addressed your comments :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup, code looks fine now.
Squashed and merged, even with that GItHub Action warning for tutorials something something. |
This snippet demonstrates HowTo do the following:
howToInjectTraceContextInSolaceMessage
howToExtractTraceContextIfAnyFromSolaceMessage
howToCreateSpanAndBaggageOnMessagePublish
howToCreateNewSpanOnMessageReceive
NOTE: The
build.gradle
andpom.xml
will need to be updated with dependencies for PS+ Java OTEL integration module (new dependency), Open-telemetry (new dependency) and also update the PS+ Java dependency once the context propagation feature is released. (solace-messaging-client to 1.7.0)I am including the
pom.xml
&build.gradle
changes in the PR as a reminder to myself for what needs to updated after the release.^ Both have now been correctly updated ✅