feat(act): add act #3
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bosi95
requested changes
Aug 13, 2024
src/bee.ts
Outdated
| @@ -297,6 +299,66 @@ export class Bee { | |||
| return chunk.download(this.getRequestOptionsForCall(options), reference) | |||
| } | |||
|
|
|||
| /** | |||
| * Adds grantees to a postage batch. | |||
There was a problem hiding this comment.
The description is not accurate. addGrantees creates a list of grantees
There was a problem hiding this comment.
I meant that the "creates for a postage batch" is incorrect, instead something like: "it creates a list from the given array of public keys"
src/bee.ts
Outdated
| } | ||
|
|
||
| /** | ||
| * Retrieves the grantees for a given reference or ENS name. |
test/integration/modules/bzz.spec.ts
Outdated
| expect(Buffer.from(dFile.data).toString()).to.eql(data) | ||
| }) | ||
|
|
||
| it('should create grantee list', async function () { |
There was a problem hiding this comment.
the grantee tests should go under a separate 'grantee' test file because it is a separate endpoint
There was a problem hiding this comment.
New module grantee created. e8b35e0
| @@ -44,6 +44,7 @@ export async function upload( | |||
| return { | |||
| reference: response.data.reference, | |||
| tagUid: response.headers['swarm-tag'] ? makeTagUid(response.headers['swarm-tag']) : undefined, | |||
| history_address: response.headers['swarm-act-history-address'] || '', | |||
There was a problem hiding this comment.
extend the other endpoints with act history header: soc, chunk
feat(act): add grantee module for managing grantees
feat(act)!: Modify soc, chunk upload return value from Result to UploadResult
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.