ACT #11
ACT #11
Conversation
There was a problem hiding this comment.
preliminary partial review.
observe golang style:
- no underscores, only Camelcase
- no need to put non-public methods to interface
- no redundancy in names: dynamicaccess/accesslogic -> access/logic
- comment everything, never write a public function or introduce a public struct without comment. comment fields of a struct too.
- only English, no Hungarian in the code, including comments and all identifiers like variables, function names, fields
pkg/dynamicaccess/accesslogic.go
Outdated
|
|
||
| // Adds a new grantee to the ACT | ||
| func (al ActLogic) AddGrantee(ctx context.Context, storage kvs.KeyValueStore, publisherPubKey, granteePubKey *ecdsa.PublicKey, accessKeyPointer *encryption.Key) error { | ||
| var accessKey encryption.Key |
There was a problem hiding this comment.
accessKey should be initialised as a field of actLogic right?
There was a problem hiding this comment.
I think there is no need to store the accessKey as member
@zelig The act-grantees branch has the latest state of the ACT feature. We were holding on merging that into this branch, until that part becomes fully functional and without issues. We are also planning to have another look at this branch and do some refactoring and optimizations before this main feature branch PR is finalized. |
aranyia
force-pushed
the
act
branch
2 times, most recently
from
8f6be5b to
20e42fa
Compare
|
If you need to test your changes against some other (specific) beekeeper branch, you can do it by changing the beekeeper branch on this line bee/.github/workflows/beekeeper.yml Line 17 in 3a7f51e just make sure that you return it to "master" branch before the merge. |
aranyia
force-pushed
the
act
branch
2 times, most recently
from
5cb87b6 to
cb80041
Compare
Co-authored-by: Ferenc Sárai <[email protected]>
|
This branch was merged into the ethersphere/bee master branch as part of PR #4692. |
Checklist
Description
Access control (ACT) implementation
The Access Control Trie (ACT) is a data structure that stores access control information for Swarm nodes. It is used to determine whether a node has permission to access a particular resource.
SWIP
See the SWIP draft PR for more details.
Open API Spec Version Changes (if applicable)
Motivation and Context (Optional)
Related Issue (Optional)
Screenshots (if appropriate):