Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make security issues widget configurable #14

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Make security issues widget configurable #14

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@

<artifactId>sonar-widget-lab-plugin</artifactId>
<groupId>org.sonarsource.widget-lab</groupId>
<version>1.9-SNAPSHOT</version>
<version>1.11-SNAPSHOT</version>
<packaging>sonar-plugin</packaging>

<name>Widget Lab</name>
Expand Down Expand Up @@ -40,6 +40,10 @@
<id>ppapapetrou</id>
<name>Patroklos Papapetrou</name>
</developer>
<developer>
<id>InfoSec812</id>
<name>Deven Phillips</name>
</developer>
</developers>

<properties>
Expand Down
17 changes: 11 additions & 6 deletions src/main/java/org/codehaus/sonar/plugins/widgetlab/SecurityIssuesTagGlobalWidget.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,17 +19,22 @@
*/
package org.codehaus.sonar.plugins.widgetlab;

import org.sonar.api.web.AbstractRubyTemplate;
import org.sonar.api.web.Description;
import org.sonar.api.web.RubyRailsWidget;
import org.sonar.api.web.UserRole;
import org.sonar.api.web.WidgetCategory;
import org.sonar.api.web.WidgetScope;
import org.sonar.api.web.*;

@UserRole(UserRole.USER)
@Description("Issues tags for security-related issues global counts")
@WidgetCategory({"Technical Debt"})
@WidgetScope("GLOBAL")
@WidgetProperties({
@WidgetProperty(
key = "tagsOfInterest",
type = WidgetPropertyType.TEXT,
description = "Which tags should be included in this display",
defaultValue = "owasp-top10, sans-top25, owasp-a1, owasp-a2, owasp-a3, owasp-a4, owasp-a5, owasp-a6, owasp-a7, " +
"owasp-a8, owasp-a9, owasp-a10, sans-top25-insecure, sans-top25-porous, sans-top25-risky, error-handling, " +
"multi-threading,injection, denial-of-service"
)
})
public class SecurityIssuesTagGlobalWidget extends AbstractRubyTemplate implements RubyRailsWidget {

@Override
Expand Down
16 changes: 11 additions & 5 deletions src/main/java/org/codehaus/sonar/plugins/widgetlab/SecurityIssuesTagWidget.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,15 +19,21 @@
*/
package org.codehaus.sonar.plugins.widgetlab;

import org.sonar.api.web.AbstractRubyTemplate;
import org.sonar.api.web.Description;
import org.sonar.api.web.RubyRailsWidget;
import org.sonar.api.web.UserRole;
import org.sonar.api.web.WidgetCategory;
import org.sonar.api.web.*;

@UserRole(UserRole.USER)
@Description("Issues tags for security-related issues")
@WidgetCategory({"Technical Debt"})
@WidgetProperties({
@WidgetProperty(
key = "tagsOfInterest",
type = WidgetPropertyType.TEXT,
description = "Which tags should be included in this display",
defaultValue = "owasp-top10, sans-top25, owasp-a1, owasp-a2, owasp-a3, owasp-a4, owasp-a5, owasp-a6, owasp-a7, " +
"owasp-a8, owasp-a9, owasp-a10, sans-top25-insecure, sans-top25-porous, sans-top25-risky, error-handling, " +
"multi-threading,injection, denial-of-service"
)
})
public class SecurityIssuesTagWidget extends AbstractRubyTemplate implements RubyRailsWidget {

@Override
Expand Down
7 changes: 2 additions & 5 deletions src/main/resources/security_issues_tag_global_widget.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
containerId = 'security_issues_global_tag' + widget.id.to_s
maxItems = 500
title = message('widget.security_issues_tag_global.title')
tagsOfInterest = widget_properties['tagsOfInterest'].gsub(/ /,'').gsub(/,/, '","')
%>

<div class="histogram-widget" id="<%= containerId %>">
Expand All @@ -16,11 +17,7 @@
<script>
(function () {

var tagsOfInterest = ["owasp-top10", "sans-top25",
"owasp-a1", "owasp-a2", "owasp-a3", "owasp-a4", "owasp-a5",
"owasp-a6", "owasp-a7", "owasp-a8", "owasp-a9", "owasp-a10",
"sans-top25-insecure", "sans-top25-porous", "sans-top25-risky",
"error-handling", "multi-threading","injection", "denial-of-service"];
var tagsOfInterest = ["<%=tagsOfInterest%>"];

var queryParams = [
'ps=1',
Expand Down
9 changes: 3 additions & 6 deletions src/main/resources/security_issues_tag_widget.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
containerId = 'security_issues_tag' + widget.id.to_s
maxItems = 500
title = message('widget.security_issues_tag.title')
tagsOfInterest = widget_properties['tagsOfInterest'].gsub(/ /,'').gsub(/,/, '","')

if has_role?(:user, @project) && !Internal.issues.listTagsForComponent(@project.uuid, maxItems).isEmpty()
search_options = {
Expand All @@ -18,7 +19,7 @@
%>

<div class="histogram-widget" id="<%= containerId %>">
<!--[if lte IE 8 ]> <h3><%= message('widget.unsupported_browser_warning') -%></h3> <![endif]-->
<!--[if lte IE 8 ]> <h3><%= message('widget.unsupported_browser_warning') %></h3> <![endif]-->

<!--[if (gte IE 9)|!(IE)]><!-->
<h3 style="margin-bottom: 5px;"><%= title -%></h3>
Expand All @@ -30,11 +31,7 @@
<script>
(function () {

var tagsOfInterest = ["owasp-top10", "sans-top25",
"owasp-a1", "owasp-a2", "owasp-a3", "owasp-a4", "owasp-a5",
"owasp-a6", "owasp-a7", "owasp-a8", "owasp-a9", "owasp-a10",
"sans-top25-insecure", "sans-top25-porous", "sans-top25-risky",
"error-handling", "multi-threading","injection", "denial-of-service"];
var tagsOfInterest = ["<%= tagsOfInterest%>"];

var createdAfter = '';
<% if @dashboard_configuration.selected_period? -%>
Expand Down