PLUGINAPI-103 Revert addition of impacts on ActiveRules

CHANGELOG.md

@@ -1,8 +1,5 @@
 # Changelog
 
-## 10.12
-* Introduce impacts on `org.sonar.api.batch.rule.ActiveRule`
-
 ## 10.11
 * Introduce new impact severities `org.sonar.api.issue.impact.Severity.INFO` and `org.sonar.api.issue.impact.Severity.BLOCKER`
 

plugin-api/src/main/java/org/sonar/api/batch/rule/ActiveRule.java

@@ -22,13 +22,11 @@
 import java.util.Map;
 import javax.annotation.CheckForNull;
 import javax.annotation.concurrent.Immutable;
-
-import org.sonar.api.issue.impact.Severity;
-import org.sonar.api.issue.impact.SoftwareQuality;
 import org.sonar.api.rule.RuleKey;
 
 /**
  * Configuration of a rule activated on a Quality profile
+ *
  * @since 4.2
  */
 @Immutable
@@ -38,15 +36,11 @@ public interface ActiveRule {
 
   /**
    * Non-null severity.
+   *
    * @see org.sonar.api.rule.Severity
    */
   String severity();
 
-  /**
-   * Overridden impact severities from the rule.
-   */
-  Map<SoftwareQuality, Severity> impacts();
-
   /**
    * Language of rule, for example <code>java</code>
    */
@@ -74,13 +68,15 @@ public interface ActiveRule {
 
   /**
    * Optional rule key of the template rule.
+   *
    * @since 4.5.3
    */
   @CheckForNull
   String templateRuleKey();
 
   /**
    * Key of the quality profile the rule belongs to.
+   *
    * @since 7.5
    */
   String qpKey();

plugin-api/src/main/java/org/sonar/api/batch/rule/LoadedActiveRule.java

@@ -27,6 +27,10 @@
 import org.sonar.api.issue.impact.SoftwareQuality;
 import org.sonar.api.rule.RuleKey;
 
+/**
+ * @deprecated since 10.13. Internal implementation
+ */
+@Deprecated(since = "10.13", forRemoval = true)
 public class LoadedActiveRule {
   private RuleKey ruleKey;
   private String severity;

plugin-api/src/test/java/org/sonar/api/batch/rule/ChecksTest.java

@@ -26,8 +26,6 @@
 import org.junit.jupiter.api.Test;
 import org.junit.jupiter.api.extension.RegisterExtension;
 import org.slf4j.event.Level;
-import org.sonar.api.issue.impact.Severity;
-import org.sonar.api.issue.impact.SoftwareQuality;
 import org.sonar.api.rule.RuleKey;
 import org.sonar.api.testfixtures.log.LogTesterJUnit5;
 
@@ -152,11 +150,6 @@ public String severity() {
       return null;
     }
 
-    @Override
-    public Map<SoftwareQuality, Severity> impacts() {
-      return Map.of();
-    }
-
     @Override
     public String language() {
       return null;