Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SLE-983: Handle Standard and MQR mode correctly #765

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

thahnen
Copy link
Member

@thahnen thahnen commented Nov 15, 2024

SLE-983

For SQ-S 10.8+ handle the different modes correctly in Connected Mode. For SQ-S 9.9 LTA handle the Standard mode correctly as there hasn't been any MQR mode yet. For SQ-S 10.0-10.7 handle the MQR mode as it was the default for these versions. For Standalone Mode handle MQR mode.

@thahnen thahnen force-pushed the feat/tha/MMF-4047_StandardMQR branch 2 times, most recently from 1e16c5d to 05d4209 Compare November 15, 2024 14:40
@thahnen thahnen marked this pull request as ready for review November 15, 2024 15:57
Copy link
Member

@nquinquenel nquinquenel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Looks clean 😄

For SQ-S 10.8+ handle the different modes correctly in Connected Mode.
For SQ-S 9.9 LTA handle the Standard mode correctly as there hasn't been any MQR mode yet.
For SQ-S 10.0-10.7 handle the MQR mode as it was the default for that time.
For Standalone Mode handle MQR mode.
@thahnen thahnen force-pushed the feat/tha/MMF-4047_StandardMQR branch from 05d4209 to 7f80671 Compare November 18, 2024 11:03
@thahnen thahnen merged commit 96913d5 into master Nov 18, 2024
15 checks passed
@thahnen thahnen deleted the feat/tha/MMF-4047_StandardMQR branch November 18, 2024 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants