Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SLE-910: Remove username/password authentication #768

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

thahnen
Copy link
Member

@thahnen thahnen commented Nov 20, 2024

SLE-910

To still work on existing username/password based connections, the background logic still exists. This only removes the wizard pages for selecting the authentication type and the username/password authentication page that was already deprecated a year ago.

But when an old username/password-based connection is used (from before this update) and edited, only the option to input a token is available (and therefore, this method of authentication can be switched to). We correctly handle the switch to a token-based authentication model.

To still work on existing username/password based connections, the background logic still exists.

But when having an old username/password based connection and editing it, there is only the option to input a token (and therefore switch to this method for authentication).
@thahnen thahnen force-pushed the task/tha/SLE-910_UserPassDepr branch from fca513f to d9c5a35 Compare November 20, 2024 15:41
Copy link

sonarqube-next bot commented Nov 20, 2024

@thahnen thahnen marked this pull request as ready for review November 21, 2024 09:50
Copy link
Member

@nquinquenel nquinquenel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Can you make sure with our PM that we now can effectively remove username/password auth?

@thahnen thahnen merged commit bc08ce2 into master Nov 25, 2024
17 checks passed
@thahnen thahnen deleted the task/tha/SLE-910_UserPassDepr branch November 25, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants