SLVS-1731 Remove ISecondaryIssueHashUpdater & SQService.GetSourceCode…

…Async (#5927)
SonarSource · Dec 27, 2024 · 381e0d9 · 381e0d9
1 parent 730a567
commit 381e0d9
Show file tree

Hide file tree

Showing 14 changed files with 10 additions and 600 deletions.
diff --git a/src/SonarQube.Client.Tests/CallRealServerTestHarness.cs b/src/SonarQube.Client.Tests/CallRealServerTestHarness.cs
diff --git a/src/SonarQube.Client.Tests/Helpers/SecondaryLocationHashUpdaterTests.cs b/src/SonarQube.Client.Tests/Helpers/SecondaryLocationHashUpdaterTests.cs
diff --git a/src/SonarQube.Client.Tests/Requests/DefaultConfiguration_Configure_Tests.cs b/src/SonarQube.Client.Tests/Requests/DefaultConfiguration_Configure_Tests.cs
@@ -39,7 +39,6 @@ public void ConfigureSonarQube_Writes_Debug_Messages()
             "Registered SonarQube.Client.Api.V2_10.GetVersionRequest for 2.1",
             "Registered SonarQube.Client.Api.V2_60.GetPropertiesRequest for 2.6",
             "Registered SonarQube.Client.Api.V3_30.ValidateCredentialsRequest for 3.3",
-            "Registered SonarQube.Client.Api.V5_00.GetSourceCodeRequest for 5.0",
             "Registered SonarQube.Client.Api.V5_10.GetIssuesRequest for 5.1",
             "Registered SonarQube.Client.Api.V5_10.GetLanguagesRequest for 5.1",
             "Registered SonarQube.Client.Api.V5_20.GetQualityProfileChangeLogRequest for 5.2",
@@ -88,7 +87,6 @@ public void ConfigureSonarCloud_Writes_Debug_Messages()
         {
             "Registered SonarQube.Client.Api.V2_10.GetVersionRequest",
             "Registered SonarQube.Client.Api.V3_30.ValidateCredentialsRequest",
-            "Registered SonarQube.Client.Api.V5_00.GetSourceCodeRequest",
             "Registered SonarQube.Client.Api.V5_10.GetLanguagesRequest",
             "Registered SonarQube.Client.Api.V5_40.GetModulesRequest",
             "Registered SonarQube.Client.Api.V10_2.GetRulesWithCCTRequest",
@@ -141,7 +139,6 @@ public void ConfigureSonarQube_CheckAllRequestsImplemented()
         testSubject.Create<IGetRulesRequest>(serverInfo).Should().NotBeNull();
         testSubject.Create<IGetVersionRequest>(serverInfo).Should().NotBeNull();
         testSubject.Create<IValidateCredentialsRequest>(serverInfo).Should().NotBeNull();
-        testSubject.Create<IGetSourceCodeRequest>(serverInfo).Should().NotBeNull();
         testSubject.Create<IGetProjectBranchesRequest>(serverInfo).Should().NotBeNull();
         testSubject.Create<IGetExclusionsRequest>(serverInfo).Should().NotBeNull();
         testSubject.Create<IGetSonarLintEventStream>(serverInfo).Should().NotBeNull();
@@ -172,7 +169,6 @@ public void ConfigureSonarCloud_CheckAllRequestsImplemented()
         testSubject.Create<IGetRulesRequest>(serverInfo).Should().NotBeNull();
         testSubject.Create<IGetVersionRequest>(serverInfo).Should().NotBeNull();
         testSubject.Create<IValidateCredentialsRequest>(serverInfo).Should().NotBeNull();
-        testSubject.Create<IGetSourceCodeRequest>(serverInfo).Should().NotBeNull();
         testSubject.Create<IGetProjectBranchesRequest>(serverInfo).Should().NotBeNull();
         testSubject.Create<IGetExclusionsRequest>(serverInfo).Should().NotBeNull();
         testSubject.Create<ITransitionIssueRequest>(serverInfo).Should().NotBeNull();

diff --git a/src/SonarQube.Client.Tests/SonarQubeService_GetProjectDashboardUrl_Disconnect.cs b/src/SonarQube.Client.Tests/SonarQubeService_GetProjectDashboardUrl_Disconnect.cs
@@ -46,13 +46,13 @@ public async Task GetProjectDashboardUrl_DisconnectedInTheMiddle_NoException()
 
         protected internal override SonarQubeService CreateTestSubject()
         {
-            return new DisconnectingService(messageHandler.Object, UserAgent, logger, requestFactorySelector, secondaryIssueHashUpdater.Object);
+            return new DisconnectingService(messageHandler.Object, UserAgent, logger, requestFactorySelector);
         }
 
         internal class DisconnectingService : SonarQubeService
         {
-            internal DisconnectingService(HttpMessageHandler messageHandler, string userAgent, ILogger logger, IRequestFactorySelector requestFactorySelector, ISecondaryIssueHashUpdater secondaryIssueHashUpdater)
-                : base(messageHandler, userAgent, logger, requestFactorySelector, secondaryIssueHashUpdater, null)
+            internal DisconnectingService(HttpMessageHandler messageHandler, string userAgent, ILogger logger, IRequestFactorySelector requestFactorySelector)
+                : base(messageHandler, userAgent, logger, requestFactorySelector, null)
             {
             }