Add GetEffectiveRuleDetailsResponse & EffectiveRuleDetailsDto #5197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
georgii-borovinskikh-sonarsource
requested a review
from ugras-ergun-sonarsource
| @@ -13,4 +13,8 @@ | |||
| <ProjectReference Include="..\TestInfrastructure\TestInfrastructure.csproj" /> | |||
| </ItemGroup> | |||
|
|
|||
| <ItemGroup> | |||
| <PackageReference Update="FluentAssertions" Version="6.12.0" /> | |||
There was a problem hiding this comment.
I updated it for only one project, but maybe I should have done it for https://github.com/SonarSource/sonarlint-visualstudio/blob/86d1c450a50aa31bb3390f9a124390f01fa73337/src/SonarLint.Test.props
There was a problem hiding this comment.
Yes, you should do it there instead. We don't want to maintain in many places. Also why did you need to change version?
There was a problem hiding this comment.
I needed it for a feature that was not available in the old one
ugras-ergun-sonarsource
approved these changes
Jan 26, 2024
|
georgii-borovinskikh-sonarsource
merged commit a4613c8
into
feature/sloop-rule-meta-data
4 checks passed
ugras-ergun-sonarsource
pushed a commit
that referenced
this pull request
Feb 28, 2024
ugras-ergun-sonarsource
pushed a commit
that referenced
this pull request
Apr 3, 2024
ugras-ergun-sonarsource
pushed a commit
that referenced
this pull request
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5193