Add SLCore credentials provider implementation #5206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
georgii-borovinskikh-sonarsource
requested a review
from ugras-ergun-sonarsource
| [PartCreationPolicy(CreationPolicy.Shared)] | ||
| internal class CredentialsListener : ICredentialsListener | ||
| { | ||
| private static readonly Uri SonarCloudUri = new Uri("https://sonarcloud.io"); |
There was a problem hiding this comment.
We don't have a single source of truth type of place for this URL. Should we open a ticket for that? To refactor the code and move all redeclarations of this URL to a single place?
There was a problem hiding this comment.
yeah it makes sense
| const string password = "password123"; | ||
|
|
||
| var testSubject = CreateTestSubject(out var credentialStoreMock); | ||
| credentialStoreMock.Setup(x => x.ReadCredentials(It.Is((TargetUri uri) => UriEquals(uri, SonarCloudUri)))).Returns(new Credential(username, password)); |
There was a problem hiding this comment.
you can put SonarCloudUri as a method parameter without using It.Is for setup which would make it simpler. (no need to change)
ugras-ergun-sonarsource
approved these changes
Feb 7, 2024
georgii-borovinskikh-sonarsource
requested a review
from ugras-ergun-sonarsource
|
ugras-ergun-sonarsource
approved these changes
Feb 8, 2024
georgii-borovinskikh-sonarsource
merged commit 6a8a0b5
into
feature/sloop-rule-meta-data
7 checks passed
georgii-borovinskikh-sonarsource
deleted the
gb/slcore-credentials-impl
branch
ugras-ergun-sonarsource
pushed a commit
that referenced
this pull request
Feb 28, 2024
ugras-ergun-sonarsource
pushed a commit
that referenced
this pull request
Apr 3, 2024
ugras-ergun-sonarsource
pushed a commit
that referenced
this pull request
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5204