Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: finish RSA public key authentication #5

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

sam80180
Copy link

Whether this PR is eventually merged or not, Sonic will thank you very much for your contribution.

无论此PR最终是否合并,Sonic组织都非常感谢您的贡献。

Checklist

  • The title starts with fix, fea, or doc. | 标题为fix、feat或doc开头。
  • I have checked that there are no duplicate pull requests with this request. | 我已检查没有与此请求重复的拉取请求。
  • I have considered and confirmed that this submission is valuable to others. | 我已经考虑过,并确认这份呈件对其他人很有价值。
  • I accept that this submission may not be used. | 我接受此提交可能不会被使用。

Description

Finish RSA public key authentication.

@prlabeler prlabeler bot added the fix label May 24, 2024
@ZhouYixun ZhouYixun requested a review from aoliaoaoaojiao June 4, 2024 04:08
@aoliaoaoaojiao
Copy link
Member

Great PR, but it requires the use of CGO here, which will increase the burden on future developers. Can the C code be translated into Go, or can it be replaced with other Go libraries?

@sam80180
Copy link
Author

sam80180 commented Jun 5, 2024

Golang does not support RSA/ECB/nopadding public key decryption, that is why I have to adopt the C code from ADB source.

If you found another approach, feel free to modify it.

@aoliaoaoaojiao
Copy link
Member

Golang does not support RSA/ECB/nopadding public key decryption, that is why I have to adopt the C code from ADB source.

If you found another approach, feel free to modify it.

I have experience writing cgo, and I know that cgo development is really painful for regular engineers. So, I think this PR can be placed on another branch and periodically synced with the main branch. If there are users who need it, they can pull and build it themselves. What do you think? @ZhouYixun

@ZhouYixun ZhouYixun changed the base branch from master to feat/RSA_public_key June 5, 2024 09:17
@ZhouYixun ZhouYixun merged commit 09e948c into SonicCloudOrg:feat/RSA_public_key Jun 5, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants