Merge pull request #93 from caofengbin/feature/add_isDisplay

feat:参考W3C规范在BaseElement中增加常用的isDisplayed方法
SonicCloudOrg · Jun 27, 2023 · 32d0255 · 32d0255
2 parents d02e5f7 + c51f2ac
commit 32d0255
Show file tree

Hide file tree

Showing 5 changed files with 45 additions and 0 deletions.
diff --git a/src/main/java/org/cloud/sonic/driver/android/service/impl/AndroidElementImpl.java b/src/main/java/org/cloud/sonic/driver/android/service/impl/AndroidElementImpl.java
@@ -155,4 +155,10 @@ public byte[] screenshot() throws SonicRespException {
             throw new SonicRespException(b.getErr().getMessage());
         }
     }
+
+    @Override
+    public boolean isDisplayed() throws SonicRespException {
+        String result = getAttribute("displayed");
+        return Boolean.parseBoolean(result);
+    }
 }
diff --git a/src/main/java/org/cloud/sonic/driver/common/models/BaseElement.java b/src/main/java/org/cloud/sonic/driver/common/models/BaseElement.java
@@ -11,4 +11,11 @@ public interface BaseElement {
     String getUniquelyIdentifies() throws SonicRespException;
 
 //    List<BaseElement> getChildren() throws SonicRespException;
+    /**
+     * Is this element displayed or not?
+     * This method avoids the problem of having to parse an element's "style" attribute.
+     *
+     * @return whether the element is displayed
+     */
+    boolean isDisplayed() throws SonicRespException;
 }
diff --git a/src/main/java/org/cloud/sonic/driver/ios/service/impl/IOSElementImpl.java b/src/main/java/org/cloud/sonic/driver/ios/service/impl/IOSElementImpl.java
@@ -155,4 +155,19 @@ public byte[] screenshot() throws SonicRespException {
             throw new SonicRespException(b.getErr().getMessage());
         }
     }
+
+    @Override
+    public boolean isDisplayed() throws SonicRespException {
+        wdaClient.checkSessionId();
+        BaseResp b = wdaClient.getRespHandler().getResp(
+                HttpUtil.createGet(wdaClient.getRemoteUrl() + "/session/"
+                        + wdaClient.getSessionId() + "/element/" + id + "/displayed"));
+        if (b.getErr() == null) {
+            logger.info("get %s displayed,result is %s.", id, b.getValue().toString());
+            return Boolean.parseBoolean(b.getValue().toString());
+        } else {
+            logger.error("get %s displayed failed.", id);
+            throw new SonicRespException(b.getErr().getMessage());
+        }
+    }
 }
diff --git a/src/main/java/org/cloud/sonic/driver/poco/models/PocoElement.java b/src/main/java/org/cloud/sonic/driver/poco/models/PocoElement.java
@@ -60,6 +60,11 @@ public String getUniquelyIdentifies() throws SonicRespException {
         return currentNodeSelector;
     }
 
+    @Override
+    public boolean isDisplayed() throws SonicRespException {
+        throw new SonicRespException("poco element unrealized");
+    }
+
     @Getter
     @ToString
     @AllArgsConstructor

diff --git a/src/test/java/org/cloud/sonic/driver/ios/IOSDriverTest.java b/src/test/java/org/cloud/sonic/driver/ios/IOSDriverTest.java
@@ -300,6 +300,18 @@ public void testSetAppiumSettings() throws SonicRespException {
         iosDriver.setAppiumSettings(new JSONObject());
     }
 
+    @Test
+    public void testIsDisplayed() throws SonicRespException {
+        String value = "name CONTAINS 'QDII' AND label CONTAINS 'QDII' AND enabled == true AND visible == true";
+        IOSElement element1 = iosDriver.findElement(IOSSelector.PREDICATE, value);
+        System.out.println(element1.getUniquelyIdentifies() + ",isDisplayed=" + element1.isDisplayed());
+        System.out.println(element1.getUniquelyIdentifies() + ",rect=" + element1.getRect());
+
+        IOSElement element2 = iosDriver.findElement(IOSSelector.ACCESSIBILITY_ID, "QDII");
+        System.out.println(element2.getUniquelyIdentifies() + ",isDisplayed=" + element2.isDisplayed());
+        System.out.println(element2.getUniquelyIdentifies() + ",rect=" + element2.getRect());
+    }
+
     @AfterClass
     public static void after() throws SonicRespException {
         iosDriver.closeDriver();