Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Use W3C actions instead of MJSONWP touch actions and support multi finger touch (iOS) #143

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

bingosam
Copy link
Contributor

@bingosam bingosam commented Sep 30, 2024

Whether this PR is eventually merged or not, Sonic will thank you very much for your contribution.

无论此PR最终是否合并,Sonic组织都非常感谢您的贡献。

Checklist

  • The title starts with fix, fea, or doc. | 标题为fix、feat或doc开头。
  • I have checked that there are no duplicate pull requests with this request. | 我已检查没有与此请求重复的拉取请求。
  • I have considered and confirmed that this submission is valuable to others. | 我已经考虑过,并确认这份呈件对其他人很有价值。
  • I accept that this submission may not be used. | 我接受此提交可能不会被使用。

Description

WDA has been supporting W3C touch actions for a long time, and multi finger touch may be useful, such as zooming in and out.

https://github.com/appium/WebDriverAgent/commits/9fd58b6c43ddeefd22ef379f8a92c867dfb4974b/WebDriverAgentLib/Commands/FBTouchActionCommands.m

@prlabeler prlabeler bot added the feature label Sep 30, 2024
Copy link
Member

@ZhouYixun ZhouYixun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

have you test it?

@ZhouYixun
Copy link
Member

ZhouYixun commented Oct 10, 2024

#132 @sam80180

@bingosam
Copy link
Contributor Author

I have tested on WDA versions 4.15.1(iOS 14 and down), 5.15.8, and 8.9.2

@ZhouYixun
Copy link
Member

Ok, someone has made two compatible ones before, I think it might be a better choice to replace them directly with w3c

@ZhouYixun ZhouYixun merged commit 814db54 into SonicCloudOrg:main Oct 10, 2024
2 checks passed
@ZhouYixun
Copy link
Member

I have tested it, it works fine, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants