This repository has been archived by the owner on Aug 6, 2024. It is now read-only.
3번째 과제 PR #29
Open
3번째 과제 PR #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@k0000k |
|
@k0000k |
findstar
suggested changes
Jul 24, 2022
|
패키지 생성, 인터페이스를 이용한 RandomGo와 AlwaysGo 분리, 피드백 주신 리팩터링 완료했습니다. |
findstar
suggested changes
Jul 27, 2022
|
줌 수업 때 피드백 주신 피드백과 남겨주신 코멘트를 바탕으로 전체적인 구조를 많이 수정 하였습니다.
|
|
아래 사항을 수정했습니다.
|
|
피드백 주신 Record를 다른 클래스로 분리하고, 그에 따른 테스트 코드를 수정했습니다. |
|
Cars의 도메인 메소드들을 Cars 클래스로 옮겨서 기존에 존재하던 문제인 Depth가 깊어진 문제를 해결해보려고 했습니다. 최대한 getter사용을 자제하고 도메인 메소드가 return해주는 방식을 사용해봤는데... 더 수정할 수 있는 부분이 있는지 궁금합니다! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.